netdev - Re: [PATCH net-next] r8169: refactor chip version detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z/9TUjJwBZtBRfs5@mev-dev.igk.intel.com>
Date: Wed, 16 Apr 2025 08:50:58 +0200
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Realtek linux nic maintainers <nic_swsd@...ltek.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: refactor chip version detection

On Tue, Apr 15, 2025 at 09:29:34PM +0200, Heiner Kallweit wrote:
> Refactor chip version detection and merge both configuration tables.
> Apart from reducing the code by a third, this paves the way for
> merging chip version handling if only difference is the firmware.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  drivers/net/ethernet/realtek/r8169_main.c | 325 +++++++++-------------
>  1 file changed, 128 insertions(+), 197 deletions(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index 8e62b1095..b55a691c5 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c

Nice simplification, thanks
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

[...]