netdev - Re: [PATCH v3 1/8] ref_tracker: don't use %pK in pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250417152453-5cb4e42b-ec66-4150-a8f8-4ec7b4e06cc0@linutronix.de>
Date: Thu, 17 Apr 2025 15:25:33 +0200
From: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
To: Jeff Layton <jlayton@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Kuniyuki Iwashima <kuniyu@...zon.com>, Qasim Ijaz <qasdev00@...il.com>, 
	Nathan Chancellor <nathan@...nel.org>, Andrew Lunn <andrew@...n.ch>, linux-kernel@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH v3 1/8] ref_tracker: don't use %pK in pr_ostream() output

On Thu, Apr 17, 2025 at 09:11:04AM -0400, Jeff Layton wrote:
> As Thomas Weißschuh points out [1], it is now preferable to use %p
> instead of hashed pointers with printk(), since raw pointers should no
> longer be leaked into the kernel log. Change the ref_tracker
> infrastructure to use %p instead of %pK in its formats.
> 
> [1]: https://lore.kernel.org/netdev/20250414-restricted-pointers-net-v1-0-12af0ce46cdd@linutronix.de/
> 
> Cc: "Thomas Weißschuh" <thomas.weissschuh@...utronix.de>
> Signed-off-by: Jeff Layton <jlayton@...nel.org>

Thanks,

Reviewed-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>

> ---
>  lib/ref_tracker.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c
> index cf5609b1ca79361763abe5a3a98484a3ee591ff2..de71439e12a3bab6456910986fa611dfbdd97980 100644
> --- a/lib/ref_tracker.c
> +++ b/lib/ref_tracker.c
> @@ -96,7 +96,7 @@ __ref_tracker_dir_pr_ostream(struct ref_tracker_dir *dir,
>  
>  	stats = ref_tracker_get_stats(dir, display_limit);
>  	if (IS_ERR(stats)) {
> -		pr_ostream(s, "%s@%pK: couldn't get stats, error %pe\n",
> +		pr_ostream(s, "%s@%p: couldn't get stats, error %pe\n",
>  			   dir->name, dir, stats);
>  		return;
>  	}
> @@ -107,13 +107,13 @@ __ref_tracker_dir_pr_ostream(struct ref_tracker_dir *dir,
>  		stack = stats->stacks[i].stack_handle;
>  		if (sbuf && !stack_depot_snprint(stack, sbuf, STACK_BUF_SIZE, 4))
>  			sbuf[0] = 0;
> -		pr_ostream(s, "%s@%pK has %d/%d users at\n%s\n", dir->name, dir,
> +		pr_ostream(s, "%s@%p has %d/%d users at\n%s\n", dir->name, dir,
>  			   stats->stacks[i].count, stats->total, sbuf);
>  		skipped -= stats->stacks[i].count;
>  	}
>  
>  	if (skipped)
> -		pr_ostream(s, "%s@%pK skipped reports about %d/%d users.\n",
> +		pr_ostream(s, "%s@%p skipped reports about %d/%d users.\n",
>  			   dir->name, dir, skipped, stats->total);
>  
>  	kfree(sbuf);
> 
> -- 
> 2.49.0
>