netdev - Re: [PATCH v3 6/8] ref_tracker: widen the ref_tracker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c635c6024a18e9a3bd1f3832521f1976377fe314.camel@kernel.org>
Date: Thu, 17 Apr 2025 17:27:05 -0400
From: Jeff Layton <jlayton@...nel.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: Andrew Morton <akpm@...ux-foundation.org>, "David S. Miller"
	 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
	 <horms@...nel.org>, Kuniyuki Iwashima <kuniyu@...zon.com>, Qasim Ijaz
	 <qasdev00@...il.com>, Nathan Chancellor <nathan@...nel.org>, 
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v3 6/8] ref_tracker: widen the ref_tracker_dir.name field

On Thu, 2025-04-17 at 21:29 +0200, Andrew Lunn wrote:
> On Thu, Apr 17, 2025 at 09:11:09AM -0400, Jeff Layton wrote:
> > Currently it's 32 bytes, but with the need to move to unique names for
> > debugfs files, that won't be enough. Move to a 64 byte name field.
> > 
> > Signed-off-by: Jeff Layton <jlayton@...nel.org>
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 


Thanks for the review!

It occurs to me that we don't technically need this patch, since
ref_tracker_dir_debugfs() doesn't overwrite dir->name in this version.
Perhaps we should drop this patch, or I could define the
REF_TRACKER_NAMESZ constant and just leave it at 32?

-- 
Jeff Layton <jlayton@...nel.org>