netdev - Re: [PATCH net-next v3 1/2] net: txgbe: Support to set UDP tunnel port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250417165736.15d212ec@kernel.org>
Date: Thu, 17 Apr 2025 16:57:36 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: netdev@...r.kernel.org, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com, horms@...nel.org,
 dlemoal@...nel.org, jdamato@...tly.com, saikrishnag@...vell.com,
 vadim.fedorenko@...ux.dev, przemyslaw.kitszel@...el.com,
 ecree.xilinx@...il.com, rmk+kernel@...linux.org.uk,
 mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next v3 1/2] net: txgbe: Support to set UDP tunnel
 port

On Thu, 17 Apr 2025 16:03:27 +0800 Jiawen Wu wrote:
> @@ -392,6 +393,8 @@ static int txgbe_open(struct net_device *netdev)
                                 ^^^^^^^^^^
>  
>  	txgbe_up_complete(wx);
>  
> +	udp_tunnel_nic_reset_ntf(netdev);
        ^^^^^^^^^^^^^^^^^^^^^^^^
>  	return 0;

> +	.flags		= UDP_TUNNEL_NIC_INFO_OPEN_ONLY,

Documentation says:

        /* Device only supports offloads when it's open, all ports
         * will be removed before close and re-added after open.
         */
        UDP_TUNNEL_NIC_INFO_OPEN_ONLY   = BIT(1),

Are you sure you have to explicitly reset?