netdev - Re: [PATCH v3 net-next 2/8] dt-bindings: dpll: Add support for Microchip Azurite chip family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250417-warping-weightless-puffin-d1c9c8@shite>
Date: Thu, 17 Apr 2025 07:54:12 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Ivan Vecera <ivecera@...hat.com>
Cc: "Rob Herring (Arm)" <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, netdev@...r.kernel.org, 
	Prathosh Satish <Prathosh.Satish@...rochip.com>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>, 
	Kees Cook <kees@...nel.org>, Michal Schmidt <mschmidt@...hat.com>, 
	Conor Dooley <conor+dt@...nel.org>, Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>, 
	linux-hardening@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, 
	linux-kernel@...r.kernel.org, Lee Jones <lee@...nel.org>, Jiri Pirko <jiri@...nulli.us>, 
	Andy Shevchenko <andy@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 net-next 2/8] dt-bindings: dpll: Add support for
 Microchip Azurite chip family

On Wed, Apr 16, 2025 at 08:29:33PM GMT, Ivan Vecera wrote:
> On Wed, Apr 16, 2025 at 7:42 PM Rob Herring (Arm) <robh@...nel.org> wrote:
> >
> >
> > On Wed, 16 Apr 2025 18:21:38 +0200, Ivan Vecera wrote:
> > > Add DT bindings for Microchip Azurite DPLL chip family. These chips
> > > provides up to 5 independent DPLL channels, 10 differential or
> > > single-ended inputs and 10 differential or 20 single-ended outputs.
> > > It can be connected via I2C or SPI busses.
> > >
> > > Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> > > ---
> > > v1->v3:
> > > * single file for both i2c & spi
> > > * 5 compatibles for all supported chips from the family
> > > ---
> > >  .../bindings/dpll/microchip,zl30731.yaml      | 115 ++++++++++++++++++
> > >  1 file changed, 115 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/dpll/microchip,zl30731.yaml
> > >
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dpll/microchip,zl30731.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
> >          $id: http://devicetree.org/schemas/dpll/microchip,zl3073x.yaml
> 
> Oops, my bad... I forgot to update $id after rename of the file...
> Will fix.

No, you forgot to test. You are expected to build your code (and this is
here testing) BEFORE you post, not after or not through community
resources.