netdev - Re: [PATCH 02/13] dt-bindings: interrupt-controller: via,vt8500-intc: Convert to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABjd4YyQVGZROse9kJtV1pEk0uk+=2h86cAyB1aCujg7+9SZEg@mail.gmail.com>
Date: Thu, 17 Apr 2025 10:15:59 +0400
From: Alexey Charkov <alchark@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Andi Shyti <andi.shyti@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Uwe Kleine-König <ukleinek@...nel.org>, 
	Daniel Lezcano <daniel.lezcano@...aro.org>, linux-arm-kernel@...ts.infradead.org, 
	linux-i2c@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org, 
	netdev@...r.kernel.org, linux-pwm@...r.kernel.org
Subject: Re: [PATCH 02/13] dt-bindings: interrupt-controller: via,vt8500-intc:
 Convert to YAML

On Thu, Apr 17, 2025 at 12:10 AM Rob Herring <robh@...nel.org> wrote:
>
> On Wed, Apr 16, 2025 at 12:21:27PM +0400, Alexey Charkov wrote:
> > Rewrite the textual description for the VIA/WonderMedia interrupt
> > controller as YAML schema.
> >
> > Signed-off-by: Alexey Charkov <alchark@...il.com>
> > ---
> >  .../interrupt-controller/via,vt8500-intc.txt       | 16 --------
> >  .../interrupt-controller/via,vt8500-intc.yaml      | 47 ++++++++++++++++++++++
> >  MAINTAINERS                                        |  1 +
> >  3 files changed, 48 insertions(+), 16 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/via,vt8500-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/via,vt8500-intc.txt
> > deleted file mode 100644
> > index 0a4ce1051b0252bbbdeef3288b90e9913d3f16f0..0000000000000000000000000000000000000000
> > --- a/Documentation/devicetree/bindings/interrupt-controller/via,vt8500-intc.txt
> > +++ /dev/null
> > @@ -1,16 +0,0 @@
> > -VIA/Wondermedia VT8500 Interrupt Controller
> > ------------------------------------------------------
> > -
> > -Required properties:
> > -- compatible : "via,vt8500-intc"
> > -- reg : Should contain 1 register ranges(address and length)
> > -- #interrupt-cells : should be <1>
> > -
> > -Example:
> > -
> > -     intc: interrupt-controller@...40000 {
> > -             compatible = "via,vt8500-intc";
> > -             interrupt-controller;
> > -             reg = <0xd8140000 0x10000>;
> > -             #interrupt-cells = <1>;
> > -     };
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/via,vt8500-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/via,vt8500-intc.yaml
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..a3fbe985db276e6a3b65cc66c7de097ed0719c0c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/via,vt8500-intc.yaml
> > @@ -0,0 +1,47 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/interrupt-controller/via,vt8500-intc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: VIA and WonderMedia SoCs Interrupt Controller
> > +
> > +maintainers:
> > +  - Alexey Charkov <alchark@...il.com>
> > +
> > +allOf:
> > +  - $ref: /schemas/interrupt-controller.yaml#
> > +
> > +
> > +properties:
> > +  compatible:
> > +    const: via,vt8500-intc
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 8
>
> This wasn't in the original binding. Find to add, but note that in
> the commit msg. Here, what each of the 8 entries are must be defined.

Will do, thank you.

The primary interrupt controller only has a single line routed to the
CPU (out of the 8 outputs it technically has), while the (identical)
chained interrupt controller has all its 8 output lines routed to the
primary controller. There's not much difference between those outputs
other than the names IC1_IRQ0~7.

The original textual description only listed one interrupt, because it
worked ok with one interrupt (the chained controller can be configured
wrt. which output to trigger for each of the inputs, and those can all
be IC1_IRQ0), even though it is not a complete description of the
actual hardware.

Will reflect that in the commit message and descriptions.

Best regards,
Alexey