[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <174498488589.689807.7439507318071758979.b4-ty@kernel.dk>
Date: Fri, 18 Apr 2025 08:01:25 -0600
From: Jens Axboe <axboe@...nel.dk>
To: io-uring@...r.kernel.org, Pavel Begunkov <asml.silence@...il.com>
Cc: David Wei <dw@...idwei.uk>,
Toke Høiland-Jørgensen <toke@...hat.com>,
Jakub Kicinski <kuba@...nel.org>, Mina Almasry <almasrymina@...gle.com>,
netdev@...r.kernel.org
Subject: Re: [PATCH io_uring-6.15] io_uring/zcrx: fix late dma unmap for a
dead dev
On Fri, 18 Apr 2025 13:02:27 +0100, Pavel Begunkov wrote:
> There is a problem with page pools not dma-unmapping immediately
> when the device is going down, and delaying it until the page pool is
> destroyed, which is not allowed (see links). That just got fixed for
> normal page pools, and we need to address memory providers as well.
>
> Unmap pages in the memory provider uninstall callback, and protect it
> with a new lock. There is also a gap between a dma mapping is created
> and the mp is installed, so if the device is killed in between,
> io_uring would be hodling dma mapping to a dead device with no one to
> call ->uninstall. Move it to page pool init and rely on ->is_mapped to
> make sure it's only done once.
>
> [...]
Applied, thanks!
[1/1] io_uring/zcrx: fix late dma unmap for a dead dev
commit: f12ecf5e1c5eca48b8652e893afcdb730384a6aa
Best regards,
--
Jens Axboe
Powered by blists - more mailing lists