netdev - Re: [PATCH net] net: fix the missing unlock for detached devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHS8izMw=Rfa+AT-xCaUspb-GYvhsE1iugPM=_c-FFD+2KBE7A@mail.gmail.com>
Date: Fri, 18 Apr 2025 13:38:14 -0700
From: Mina Almasry <almasrymina@...gle.com>
To: Stanislav Fomichev <stfomichev@...il.com>
Cc: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net, netdev@...r.kernel.org, 
	edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch, 
	horms@...nel.org, jdamato@...tly.com, sdf@...ichev.me, ap420073@...il.com
Subject: Re: [PATCH net] net: fix the missing unlock for detached devices

On Fri, Apr 18, 2025 at 7:14 AM Stanislav Fomichev <stfomichev@...il.com> wrote:
>
> On 04/18, Mina Almasry wrote:
> > On Thu, Apr 17, 2025 at 6:53 PM Jakub Kicinski <kuba@...nel.org> wrote:
> > >
> > > The combined condition was left as is when we converted
> > > from __dev_get_by_index() to netdev_get_by_index_lock().
> > > There was no need to undo anything with the former, for
> > > the latter we need an unlock.
> > >
> > > Fixes: 1d22d3060b9b ("net: drop rtnl_lock for queue_mgmt operations")
> > > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> >
> > Reviewed-by: Mina Almasry <almasrymina@...gle.com>
>
> Mina, the same (unlock netedev on !present) needs to happen for
> https://lore.kernel.org/netdev/20250417231540.2780723-5-almasrymina@google.com/
>
> Presumably you'll do another repost at some point?

Yes, and there is also a lot going on in that series outside of this
locking point. If the rest of the series looks good and is merged I
can also look into porting this fix to the tx path as a follow up, if
acceptable.

-- 
Thanks,
Mina