netdev - RE: [PATCH net-next v3 1/2] net: txgbe: Support to set UDP tunnel port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01fe01dbb00a$a3fdea90$ebf9bfb0$@trustnetic.com>
Date: Fri, 18 Apr 2025 10:36:08 +0800
From: Jiawen Wu <jiawenwu@...stnetic.com>
To: "'Jakub Kicinski'" <kuba@...nel.org>
Cc: <netdev@...r.kernel.org>,
	<andrew+netdev@...n.ch>,
	<davem@...emloft.net>,
	<edumazet@...gle.com>,
	<pabeni@...hat.com>,
	<horms@...nel.org>,
	<dlemoal@...nel.org>,
	<jdamato@...tly.com>,
	<saikrishnag@...vell.com>,
	<vadim.fedorenko@...ux.dev>,
	<przemyslaw.kitszel@...el.com>,
	<ecree.xilinx@...il.com>,
	<rmk+kernel@...linux.org.uk>,
	<mengyuanlou@...-swift.com>
Subject: RE: [PATCH net-next v3 1/2] net: txgbe: Support to set UDP tunnel port

On Fri, Apr 18, 2025 10:20 AM, Jakub Kicinski wrote:
> On Fri, 18 Apr 2025 09:44:00 +0800 Jiawen Wu wrote:
> > On Fri, Apr 18, 2025 7:58 AM, Jakub Kicinski wrote:
> > > On Thu, 17 Apr 2025 16:03:27 +0800 Jiawen Wu wrote:
> > > > @@ -392,6 +393,8 @@ static int txgbe_open(struct net_device *netdev)
> > >                                  ^^^^^^^^^^
> > > >
> > > >  	txgbe_up_complete(wx);
> > > >
> > > > +	udp_tunnel_nic_reset_ntf(netdev);
> > >         ^^^^^^^^^^^^^^^^^^^^^^^^
> > > >  	return 0;
> > >
> > > > +	.flags		= UDP_TUNNEL_NIC_INFO_OPEN_ONLY,
> > >
> > > Documentation says:
> > >
> > >         /* Device only supports offloads when it's open, all ports
> > >          * will be removed before close and re-added after open.
> > >          */
> > >         UDP_TUNNEL_NIC_INFO_OPEN_ONLY   = BIT(1),
> > >
> > > Are you sure you have to explicitly reset?
> >
> > Yes. Stop device will reset hardware, which reset UDP port to the default value.
> > So it has to re-configure the ports.
> 
> My point is that this is basically what the
> UDP_TUNNEL_NIC_INFO_OPEN_ONLY flag already assumes.
> There should be no need to reset if you already told the core
> with the flag that the device forgets everything when closed.
> 
> Could you retest without the reset_ntf ?

Thanks for the guidance.
The test result looks the same as before, when I remove reset_ntf.
I'll fix it in patch v4. :)