netdev - RE: [PATCH net-next v3 1/2] net: stmmac: Refactor VLAN implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BN8PR03MB5073FDF1D834404244D50790B4B82@BN8PR03MB5073.namprd03.prod.outlook.com>
Date: Mon, 21 Apr 2025 16:52:12 +0000
From: "Ng, Boon Khai" <boon.khai.ng@...era.com>
To: Simon Horman <horms@...nel.org>, Furong Xu <0x1207@...il.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
	Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin
	<mcoquelin.stm32@...il.com>, Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Russell King <linux@...linux.org.uk>, Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer
	<hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, "Gerlach,
 Matthew" <matthew.gerlach@...era.com>, "Ang, Tien Sung"
	<tien.sung.ang@...era.com>, "Tham, Mun Yew" <mun.yew.tham@...era.com>, "G
 Thomas, Rohan" <rohan.g.thomas@...era.com>
Subject: RE: [PATCH net-next v3 1/2] net: stmmac: Refactor VLAN implementation

> > I can confirm that 802.1ad (QinQ) has been broken on stmmac for years,
> > and it will be so nice if this refactoring includes some fixes for
> > QinQ
> 
> FWIIW, please be sure that fixes are separate patches from refactoring.

Hi Furong, Simon,

This refactor is intended to combine the VLAN driver for dwmac4 and 
dwxgmac2. From our perspective, on our board, we do not actually
use the QinQ feature of the xgmac2 IP.

However, I agree with Simon that the fixes should be separate from
the refactoring process

Regards,
Boon Khai.