netdev - Re: [PATCH v3 4/9] vhost: modify vhost_log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACGkMEsU2nnTD7akj8im+UBYMjbyyUSAq7U9+uVS8_USAK81eQ@mail.gmail.com>
Date: Mon, 21 Apr 2025 11:08:10 +0800
From: Jason Wang <jasowang@...hat.com>
To: Dongli Zhang <dongli.zhang@...cle.com>
Cc: virtualization@...ts.linux.dev, kvm@...r.kernel.org, 
	netdev@...r.kernel.org, mst@...hat.com, michael.christie@...cle.com, 
	pbonzini@...hat.com, stefanha@...hat.com, eperezma@...hat.com, 
	joao.m.martins@...cle.com, joe.jin@...cle.com, si-wei.liu@...cle.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/9] vhost: modify vhost_log_write() for broader users

On Thu, Apr 3, 2025 at 2:32 PM Dongli Zhang <dongli.zhang@...cle.com> wrote:
>
> Currently, the only user of vhost_log_write() is vhost-net. The 'len'
> argument prevents logging of pages that are not tainted by the RX path.
>
> Adjustments are needed since more drivers (i.e. vhost-scsi) begin using
> vhost_log_write(). So far vhost-net RX path may only partially use pages
> shared via the last vring descriptor. Unlike vhost-net, vhost-scsi always
> logs all pages shared via vring descriptors. To accommodate this,
> use (len == U64_MAX) to indicate whether the driver would log all pages of
> vring descriptors, or only pages that are tainted by the driver.
>
> In addition, removes BUG().
>
> Suggested-by: Joao Martins <joao.m.martins@...cle.com>
> Signed-off-by: Dongli Zhang <dongli.zhang@...cle.com>

Acked-by: Jason Wang <jasowang@...hat.com>

Thanks