netdev - Re: [PATCH v2 net-next 2/3] ionic: support ethtool get_module_eeprom_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250421105428.GB2789685@horms.kernel.org>
Date: Mon, 21 Apr 2025 11:54:28 +0100
From: Simon Horman <horms@...nel.org>
To: Shannon Nelson <shannon.nelson@....com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, brett.creeley@....com
Subject: Re: [PATCH v2 net-next 2/3] ionic: support ethtool
 get_module_eeprom_by_page

On Tue, Apr 15, 2025 at 04:13:15PM -0700, Shannon Nelson wrote:
> Add support for the newer get_module_eeprom_by_page interface.
> Only the upper half of the 256 byte page is available for
> reading, and the firmware puts the two sections into the
> extended sprom buffer, so a union is used over the extended
> sprom buffer to make clear which page is to be accessed.
> 
> With get_module_eeprom_by_page implemented there is no need
> for the older get_module_info or git_module_eeprom interfaces,
> so remove them.
> 
> Reviewed-by: Brett Creeley <brett.creeley@....com>
> Signed-off-by: Shannon Nelson <shannon.nelson@....com>

Reviewed-by: Simon Horman <horms@...nel.org>