netdev - Re: [PATCH v11 net-next 5/5] sched: Add enqueue/dequeue of dualpi2 qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2921eea-1430-4626-9419-eb04dc2ec23d@redhat.com>
Date: Tue, 22 Apr 2025 12:21:17 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: chia-yu.chang@...ia-bell-labs.com, xandfury@...il.com,
 netdev@...r.kernel.org, dave.taht@...il.com, jhs@...atatu.com,
 kuba@...nel.org, stephen@...workplumber.org, xiyou.wangcong@...il.com,
 jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com,
 horms@...nel.org, andrew+netdev@...n.ch, donald.hunter@...il.com,
 ast@...erby.net, liuhangbin@...il.com, shuah@...nel.org,
 linux-kselftest@...r.kernel.org, ij@...nel.org, ncardwell@...gle.com,
 koen.de_schepper@...ia-bell-labs.com, g.white@...lelabs.com,
 ingemar.s.johansson@...csson.com, mirja.kuehlewind@...csson.com,
 cheshire@...le.com, rs.ietf@....at, Jason_Livingood@...cast.com,
 vidhi_goel@...le.com
Cc: Olga Albisser <olga@...isser.org>,
 Olivier Tilmans <olivier.tilmans@...ia.com>,
 Henrik Steen <henrist@...rist.net>, Bob Briscoe <research@...briscoe.net>
Subject: Re: [PATCH v11 net-next 5/5] sched: Add enqueue/dequeue of dualpi2
 qdisc

On 4/15/25 2:43 PM, chia-yu.chang@...ia-bell-labs.com wrote:
> +static struct sk_buff *dualpi2_qdisc_dequeue(struct Qdisc *sch)
> +{
> +	struct dualpi2_sched_data *q = qdisc_priv(sch);
> +	struct sk_buff *skb;
> +	int credit_change;
> +	u64 now;
> +
> +	now = ktime_get_ns();
> +
> +	while ((skb = dequeue_packet(sch, q, &credit_change, now))) {
> +		if (!q->drop_early && must_drop(sch, q, skb)) {
> +			drop_and_retry(q, skb, sch,
> +				       SKB_DROP_REASON_QDISC_CONGESTED);
> +			continue;
> +		}
> +
> +		if (skb_in_l_queue(skb) && do_step_aqm(q, skb, now)) {
> +			qdisc_qstats_drop(q->l_queue);
> +			drop_and_retry(q, skb, sch,
> +				       SKB_DROP_REASON_DUALPI2_STEP_DROP);
> +			continue;
> +		}
> +
> +		q->c_protection.credit += credit_change;
> +		qdisc_bstats_update(sch, skb);
> +		break;
> +	}
> +
> +	/* We cannot call qdisc_tree_reduce_backlog() if our qlen is 0,
> +	 * or HTB crashes.
> +	 */
> +	if (q->deferred_drops.cnt && qdisc_qlen(sch)) {

Since commit cd23e77e6568abfac6354dd3f69d5b154e60e342 the qdisc_qlen()
check is not needed anymore.

/P