netdev - Re: [RFC PATCH bpf-next 06/12] selftests/bpf: Adjust test that does not allow refcounted node in rbtree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP01T77kU=LmH-z1WQa-4fiC8XvF94mH1NApTxt=hEPSfYFYfg@mail.gmail.com>
Date: Tue, 22 Apr 2025 04:36:59 +0200
From: Kumar Kartikeya Dwivedi <memxor@...il.com>
To: Martin KaFai Lau <martin.lau@...ux.dev>
Cc: bpf@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>, 
	Andrii Nakryiko <andrii@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org, 
	kernel-team@...a.com, Amery Hung <ameryhung@...il.com>
Subject: Re: [RFC PATCH bpf-next 06/12] selftests/bpf: Adjust test that does
 not allow refcounted node in rbtree_remove

On Sat, 19 Apr 2025 at 00:48, Martin KaFai Lau <martin.lau@...ux.dev> wrote:
>
> From: Martin KaFai Lau <martin.lau@...nel.org>
>
> rbtree_remove now allows refcounted node now. The
> rbtree_api_remove_unadded_node test needs to be adjusted.
>
> First change, it does not expect a verifier's error now.
>
> Second change, the test now expects bpf_rbtree_remove(&groot, &m->node)
> to return NULL. The test uses __retval(0) to ensure this NULL
> return value.
>
> Some of the "only take non-owning..." failure messages are changed also.
>
> Signed-off-by: Martin KaFai Lau <martin.lau@...nel.org>
> ---

Looks good, but again, we should fold into the previous patch.