netdev - Re: [PATCH net-next v2] net: airoha: Add missing filed to ppe_mbox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAeiYFIIOyTVvMhw@lore-desk>
Date: Tue, 22 Apr 2025 16:06:24 +0200
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org,
	Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next v2] net: airoha: Add missing filed to
 ppe_mbox_data struct

> On Thu, 17 Apr 2025 11:30:47 +0200 Lorenzo Bianconi wrote:
> > The official Airoha EN7581 firmware requires adding max_packet filed in
> > ppe_mbox_data struct while the unofficial one used to develop the Airoha
> > EN7581 flowtable support does not require this field.
> > This patch does not introduce any real backwards compatible issue since
> > EN7581 fw is not publicly available in linux-firmware or other
> > repositories (e.g. OpenWrt) yet and the official fw version will use this
> > new layout. For this reason this change needs to be backported.
> > 
> > Fixes: 23290c7bc190d ("net: airoha: Introduce Airoha NPU support")
> 
> I'm not sure I agree with this fixes tag. The fixes tag should point 
> to the earliest commit where any problem may be visible. IIUC you're
> targeting net-next because the structure is not used in net. So the
> Fixes tag should also point to some commit in net-next...
> If we leave it as is after the merge window stable bot will pull this
> commit into 6.15 for no good reason.

Hi Jakub,

actually the commit below is even present in the net tree. Since this is
required to work with the official airoha firmware, I guess I should repost
targeting net with the same Fixes tag. Agree?

Regards,
Lorenzo

commit 23290c7bc190def4e1ca61610992d9b7c32e33f3
Author: Lorenzo Bianconi <lorenzo@...nel.org>
Date:   Fri Feb 28 11:54:20 2025 +0100

    net: airoha: Introduce Airoha NPU support

    Packet Processor Engine (PPE) module available on EN7581 SoC populates
    the PPE table with 5-tuples flower rules learned from traffic forwarded
    between the GDM ports connected to the Packet Switch Engine (PSE) module.
    The airoha_eth driver can enable hw acceleration of learned 5-tuples
    rules if the user configure them in netfilter flowtable (netfilter
    flowtable support will be added with subsequent patches).
    airoha_eth driver configures and collects data from the PPE module via a
    Network Processor Unit (NPU) RISC-V module available on the EN7581 SoC.
    Introduce basic support for Airoha NPU module.
    
    Tested-by: Sayantan Nandy <sayantan.nandy@...oha.com>
    Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
    Signed-off-by: Paolo Abeni <pabeni@...hat.com>

> -- 
> pw-bot: cr

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)