netdev - Re: [PATCH net-next 3/5] net: bcmasp: Remove support for asp-v2.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAf6IgSCOlWuJn_2@shell.armlinux.org.uk>
Date: Tue, 22 Apr 2025 21:20:50 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Simon Horman <horms@...nel.org>
Cc: Justin Chen <justin.chen@...adcom.com>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, rafal@...ecki.pl, hkallweit1@...il.com,
	bcm-kernel-feedback-list@...adcom.com, opendmb@...il.com,
	conor+dt@...nel.org, krzk+dt@...nel.org, robh@...nel.org,
	pabeni@...hat.com, kuba@...nel.org, edumazet@...gle.com,
	davem@...emloft.net, andrew+netdev@...n.ch,
	florian.fainelli@...adcom.com
Subject: Re: [PATCH net-next 3/5] net: bcmasp: Remove support for asp-v2.0

On Tue, Apr 22, 2025 at 07:32:35PM +0100, Simon Horman wrote:
> On Wed, Apr 16, 2025 at 03:48:13PM -0700, Justin Chen wrote:
> > The SoC that supported asp-v2.0 never saw the light of day. asp-v2.0 has
> > quirks that makes the logic overly complicated. For example, asp-v2.0 is
> > the only revision that has a different wake up IRQ hook up. Remove asp-v2.0
> > support to make supporting future HW revisions cleaner.
> > 
> > Signed-off-by: Justin Chen <justin.chen@...adcom.com>
> > ---
> >  drivers/net/ethernet/broadcom/asp2/bcmasp.c   | 98 ++-----------------
> >  drivers/net/ethernet/broadcom/asp2/bcmasp.h   | 45 ++-------
> >  .../ethernet/broadcom/asp2/bcmasp_ethtool.c   | 21 +---
> >  .../net/ethernet/broadcom/asp2/bcmasp_intf.c  |  2 +-
> >  .../ethernet/broadcom/asp2/bcmasp_intf_defs.h |  3 +-
> >  5 files changed, 23 insertions(+), 146 deletions(-)
> > 
> > diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> 
> ...
> 
> >  static const struct bcmasp_plat_data v21_plat_data = {
> > -	.init_wol = bcmasp_init_wol_shared,
> > -	.enable_wol = bcmasp_enable_wol_shared,
> > -	.destroy_wol = bcmasp_wol_irq_destroy_shared,
> >  	.core_clock_select = bcmasp_core_clock_select_one,
> > -	.hw_info = &v21_hw_info,
> > +	.eee_fixup = NULL;
> 
> 	.eee_fixup = NULL,

Even better... omit it entirely.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!