netdev - Re: [PATCH net-next] octeontx2-af: Remove unused rvu_npc_enable_bcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74650d5d-167c-4d04-8412-5ffb39d4fc6a@intel.com>
Date: Tue, 22 Apr 2025 15:05:17 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: <linux@...blig.org>, <sgoutham@...vell.com>, <lcherian@...vell.com>,
	<gakula@...vell.com>, <jerinj@...vell.com>, <hkelam@...vell.com>,
	<sbhatta@...vell.com>, <andrew+netdev@...n.ch>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] octeontx2-af: Remove unused
 rvu_npc_enable_bcast_entry



On 4/20/2025 3:58 PM, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
> 
> The last use of rvu_npc_enable_bcast_entry() was removed in 2021 by
> commit 967db3529eca ("octeontx2-af: add support for multicast/promisc
> packet replication feature")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  .../net/ethernet/marvell/octeontx2/af/rvu.h    |  2 --
>  .../ethernet/marvell/octeontx2/af/rvu_npc.c    | 18 ------------------
>  2 files changed, 20 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.h b/drivers/net/ethernet/marvell/octeontx2/af/rvu.h
> index 60f085b00a8c..147d7f5c1fcc 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.h
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.h
> @@ -969,8 +969,6 @@ void rvu_npc_enable_promisc_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
>  				  bool enable);
>  void rvu_npc_install_bcast_match_entry(struct rvu *rvu, u16 pcifunc,
>  				       int nixlf, u64 chan);
> -void rvu_npc_enable_bcast_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
> -				bool enable);
>  void rvu_npc_install_allmulti_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
>  				    u64 chan);
>  void rvu_npc_enable_allmulti_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> index 821fe242f821..6296a3cdabbb 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> @@ -820,24 +820,6 @@ void rvu_npc_install_bcast_match_entry(struct rvu *rvu, u16 pcifunc,
>  	rvu_mbox_handler_npc_install_flow(rvu, &req, &rsp);
>  }
>  
> -void rvu_npc_enable_bcast_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
> -				bool enable)
> -{

Its a bit odd since that commit also updated the signature of this
function adding the nixlf parameter, but indeed it didn't add any
callers to the function.

> -	struct npc_mcam *mcam = &rvu->hw->mcam;
> -	int blkaddr, index;
> -
> -	blkaddr = rvu_get_blkaddr(rvu, BLKTYPE_NPC, 0);
> -	if (blkaddr < 0)
> -		return;
> -
> -	/* Get 'pcifunc' of PF device */
> -	pcifunc = pcifunc & ~RVU_PFVF_FUNC_MASK;
> -
> -	index = npc_get_nixlf_mcam_index(mcam, pcifunc, nixlf,
> -					 NIXLF_BCAST_ENTRY);
> -	npc_enable_mcam_entry(rvu, mcam, blkaddr, index, enable);
> -}
> -
>  void rvu_npc_install_allmulti_entry(struct rvu *rvu, u16 pcifunc, int nixlf,
>  				    u64 chan)
>  {