netdev - Re: [PATCH net-next] r8169: use pci_prepare_to_sleep in rtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb2af494-bb50-4fbf-bf83-4b8efa7a637a@intel.com>
Date: Tue, 22 Apr 2025 15:07:55 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Heiner Kallweit <hkallweit1@...il.com>, Realtek linux nic maintainers
	<nic_swsd@...ltek.com>, Andrew Lunn <andrew+netdev@...n.ch>, Paolo Abeni
	<pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, David Miller
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Simon Horman
	<horms@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: use pci_prepare_to_sleep in rtl_shutdown



On 4/21/2025 2:25 AM, Heiner Kallweit wrote:
> Use pci_prepare_to_sleep() like PCI core does in pci_pm_suspend_noirq.
> This aligns setting a low-power mode during shutdown with the handling
> of the transition to system suspend. Also the transition to runtime
> suspend uses pci_target_state() instead of setting D3hot unconditionally.
> 
> Note: pci_prepare_to_sleep() uses device_may_wakeup() to check whether
>       device may generate wakeup events. So we don't lose anything by
>       not passing tp->saved_wolopts any longer.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  drivers/net/ethernet/realtek/r8169_main.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index b2c48d013..64e30408a 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -5028,10 +5028,8 @@ static void rtl_shutdown(struct pci_dev *pdev)
>  	/* Restore original MAC address */
>  	rtl_rar_set(tp, tp->dev->perm_addr);
>  
> -	if (system_state == SYSTEM_POWER_OFF && !tp->dash_enabled) {
> -		pci_wake_from_d3(pdev, tp->saved_wolopts);
> -		pci_set_power_state(pdev, PCI_D3hot);
> -	}
> +	if (system_state == SYSTEM_POWER_OFF && !tp->dash_enabled)
> +		pci_prepare_to_sleep(pdev);
>  }
>  
>  static void rtl_remove_one(struct pci_dev *pdev)