netdev - Re: [PATCH net v3] net: lwtunnel: disable BHs when required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250422165931.6d205a3c@kernel.org>
Date: Tue, 22 Apr 2025 16:59:31 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Justin Iurman <justin.iurman@...ege.be>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, horms@...nel.org, kuniyu@...zon.com, Alexei Starovoitov
 <alexei.starovoitov@...il.com>, Eduard Zingerman <eddyz87@...il.com>, bpf
 <bpf@...r.kernel.org>, Stanislav Fomichev <stfomichev@...il.com>, Sebastian
 Sewior <bigeasy@...utronix.de>, Andrea Mayer <andrea.mayer@...roma2.it>,
 Stefano Salsano <stefano.salsano@...roma2.it>, Paolo Lungaroni
 <paolo.lungaroni@...roma2.it>
Subject: Re: [PATCH net v3] net: lwtunnel: disable BHs when required

On Wed, 16 Apr 2025 18:07:16 +0200 Justin Iurman wrote:
> In lwtunnel_{output|xmit}(), dev_xmit_recursion() may be called in
> preemptible scope for PREEMPT kernels. This patch disables BHs before
> calling dev_xmit_recursion(). BHs are re-enabled only at the end, since
> we must ensure the same CPU is used for both dev_xmit_recursion_inc()
> and dev_xmit_recursion_dec() (and any other recursion levels in some
> cases) in order to maintain valid per-cpu counters.

Applied last night by Paolo, thanks!