netdev - Re: [REGRESSION] net: pcs-lynx: 10G SFP no longer links up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <f7eac1d6-34eb-4eba-937d-c6624f9a6826@app.fastmail.com>
Date: Wed, 23 Apr 2025 19:01:02 +1000
From: "Mathew McBride" <matt@...verse.com.au>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: "Ioana Ciornei" <ioana.ciornei@....com>,
 "David S. Miller" <davem@...emloft.net>,
 "Eric Dumazet" <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>,
 "Paolo Abeni" <pabeni@...hat.com>, netdev@...r.kernel.org,
 "Andrew Lunn" <andrew@...n.ch>, "Heiner Kallweit" <hkallweit1@...il.com>,
 regressions@...ts.linux.dev
Subject: Re: [REGRESSION] net: pcs-lynx: 10G SFP no longer links up

On Wed, Apr 23, 2025, at 2:03 AM, Russell King (Oracle) wrote:
> On Fri, Apr 18, 2025 at 01:02:19PM +1000, Mathew McBride wrote:
> > #regzbot introduced: 6561f0e547be221f411fda5eddfcc5bd8bb058a5
> > 
> > Hi Russell,
> > 
> > On Thu, Dec 5, 2024, at 8:42 PM, Russell King (Oracle) wrote:
> > > Report the PCS in-band capabilities to phylink for the Lynx PCS.
> > > 
> > 
> > The implementation of in-band capabilities has broken SFP+ (10GBase-R) mode on my LS1088 board.
> > The other ports in the system (QSGMII) work fine.
> 
> Thanks for the report.

Thanks Russell!

The diff below does fix the problem, 10G SFP's now link up again.

I should note that Alex Guzman was the one who originally reported the issue to me, he has also confirmed this diff resolves the issue.
Link: https://forum.traverse.com.au/t/sfp-ports-stop-working-with-linux-6-14-in-arch-linux/1076/4

> Please try the diff below:
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index 1bdd5d8bb5b0..2147e2d3003a 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -3624,6 +3624,15 @@ static int phylink_sfp_config_optical(struct phylink *pl)
> phylink_dbg(pl, "optical SFP: chosen %s interface\n",
>     phy_modes(interface));
>  
> + /* GBASE-R interfaces with the exception of KR do not have autoneg at
> + * the PCS. As the PCS is media facing, disable the Autoneg bit in the
> + * advertisement.
> + */
> + if (interface == PHY_INTERFACE_MODE_5GBASER ||
> +     interface == PHY_INTERFACE_MODE_10GBASER ||
> +     interface == PHY_INTERFACE_MODE_25GBASER)
> + __clear_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, config.advertising);
> +
> if (!phylink_validate_pcs_inband_autoneg(pl, interface,
> config.advertising)) {
> phylink_err(pl, "autoneg setting not compatible with PCS");
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
>