netdev - Re: [PATCH net-next V2 01/14] devlink: define enum for attr types of dynamic attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ccwchffn6gtsy7ek4dhdqaxlbch4mptjqaqmh43a3rk7uu6dxu@jfua3hr6zxvw>
Date: Wed, 23 Apr 2025 13:12:56 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Saeed Mahameed <saeed@...nel.org>, 
	"David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, 
	Eric Dumazet <edumazet@...gle.com>, Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org, 
	Tariq Toukan <tariqt@...dia.com>, Gal Pressman <gal@...dia.com>, Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next V2 01/14] devlink: define enum for attr types of
 dynamic attributes

Tue, Apr 22, 2025 at 04:55:24PM +0200, kuba@...nel.org wrote:
>On Tue, 22 Apr 2025 11:14:36 +0200 Jiri Pirko wrote:
>> >Ugh, I thought enum netlink_attribute_type matches the values :|
>> >And user space uses MNL_ types.
>> >
>> >Please don't invent _DYN_ATTR at least. Why not PARAM_TYPE ?  
>> 
>> Because it is used for both params and health reporters (fmsg).
>
>I see. Still, a better name is needed. "Dynamic" sounds too positive,
>and the construct is a dead end and a misunderstanding of netlink.

VAR_ATTR? Any other suggestion?

>
>Coincidentally - you added it to the YNL spec but didn't set it for 
>the attrs that carry the values of the enum.

True. Will drop it.