netdev - Re: [RESEND PATCH 1/2] TCP: note received valid-cookie Fast Open option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b613e5d2-b1f0-4d3c-833e-969abf2af082@exim.org>
Date: Wed, 23 Apr 2025 12:43:45 +0100
From: jgh@...m.org
To: Paolo Abeni <pabeni@...hat.com>, Jeremy Harris <jgh@...m.org>,
 netdev@...r.kernel.org
Cc: edumazet@...gle.com, ncardwell@...gle.com
Subject: Re: [RESEND PATCH 1/2] TCP: note received valid-cookie Fast Open
 option

Thanks for the review.  I'm preparing a v2, and a patch to "ss" in iproute2.

On 2025/04/22 11:36 AM, Paolo Abeni wrote:
> The commit description is missing.

Ack.

>> +		syn_fastopen_in:1; /* Received SYN includes Fast Open option */
> 
> Worth mentioning in the commit message that this will fill a bit hole.

Will do.


>> @@ -401,6 +401,7 @@ struct sock *tcp_try_fastopen(struct sock *sk, struct sk_buff *skb,
>>   				}
>>   				NET_INC_STATS(sock_net(sk),
>>   					      LINUX_MIB_TCPFASTOPENPASSIVE);
>> +				tcp_sk(child)->syn_fastopen_in = 1;
> 
> Likely you need to reset the bit on disconnect().

Added.

-- 
Cheers,
   Jeremy