netdev - Re: [PATCH bpf-next] bpf: Allow XDP dev bounded program to perform XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250422170330.71e47a70@kernel.org>
Date: Tue, 22 Apr 2025 17:03:30 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <stfomichev@...il.com>
Cc: Lorenzo Bianconi <lorenzo@...nel.org>, Alexei Starovoitov
 <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, John Fastabend
 <john.fastabend@...il.com>, Andrii Nakryiko <andrii@...nel.org>, Martin
 KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>,
 Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>, KP
 Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Hao Luo
 <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, "David S. Miller"
 <davem@...emloft.net>, Jesper Dangaard Brouer <hawk@...nel.org>,
 bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next] bpf: Allow XDP dev bounded program to perform
 XDP_REDIRECT into maps

On Tue, 22 Apr 2025 15:49:52 -0700 Stanislav Fomichev wrote:
> > +	if (map->map_type == BPF_MAP_TYPE_DEVMAP &&
> > +	    prog->expected_attach_type != BPF_XDP_DEVMAP)
> > +		return true;
> > +
> > +	if (map->map_type == BPF_MAP_TYPE_CPUMAP &&
> > +	    prog->expected_attach_type != BPF_XDP_CPUMAP)
> > +		return true;  
> 
> Not sure I understand, what does it mean exactly? That it's ok to add
> a dev-bound program to the dev/cpumap if the program itself is gonna
> be attached only to the real device? Can you expand more on the specific
> use-case?

And an upstream offload which supports it..