netdev - RE: [PATCH net-next] tools: ynl: fix the header guard name for OVPN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB5089A6F67F87DDEB7B3F0711D6BA2@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Wed, 23 Apr 2025 22:49:54 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, "davem@...emloft.net"
	<davem@...emloft.net>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Dumazet, Eric"
	<edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "horms@...nel.org"
	<horms@...nel.org>, Thorsten Leemhuis <linux@...mhuis.info>,
	"donald.hunter@...il.com" <donald.hunter@...il.com>, "danieller@...dia.com"
	<danieller@...dia.com>, "sdf@...ichev.me" <sdf@...ichev.me>
Subject: RE: [PATCH net-next] tools: ynl: fix the header guard name for OVPN



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Wednesday, April 23, 2025 3:03 PM
> To: davem@...emloft.net
> Cc: netdev@...r.kernel.org; Dumazet, Eric <edumazet@...gle.com>;
> pabeni@...hat.com; andrew+netdev@...n.ch; horms@...nel.org; Jakub Kicinski
> <kuba@...nel.org>; Thorsten Leemhuis <linux@...mhuis.info>;
> donald.hunter@...il.com; Keller, Jacob E <jacob.e.keller@...el.com>;
> danieller@...dia.com; sdf@...ichev.me
> Subject: [PATCH net-next] tools: ynl: fix the header guard name for OVPN
> 
> Thorsten reports that after upgrading system headers from linux-next
> the YNL build breaks. I typo'ed the header guard, _H is missing.
> 
> Reported-by: Thorsten Leemhuis <linux@...mhuis.info>
> Link: https://lore.kernel.org/59ba7a94-17b9-485f-aa6d-
> 14e4f01a7a39@...mhuis.info
> Fixes: 12b196568a3a ("tools: ynl: add missing header deps")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: donald.hunter@...il.com
> CC: jacob.e.keller@...el.com
> CC: danieller@...dia.com
> CC: sdf@...ichev.me
> ---
>  tools/net/ynl/Makefile.deps | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/net/ynl/Makefile.deps b/tools/net/ynl/Makefile.deps
> index 8b7bf673b686..a5e6093903fb 100644
> --- a/tools/net/ynl/Makefile.deps
> +++ b/tools/net/ynl/Makefile.deps
> @@ -27,7 +27,7 @@ CFLAGS_netdev:=$(call
> get_hdr_inc,_LINUX_NETDEV_H,netdev.h)
>  CFLAGS_nl80211:=$(call get_hdr_inc,__LINUX_NL802121_H,nl80211.h)
>  CFLAGS_nlctrl:=$(call get_hdr_inc,__LINUX_GENERIC_NETLINK_H,genetlink.h)
>  CFLAGS_nfsd:=$(call get_hdr_inc,_LINUX_NFSD_NETLINK_H,nfsd_netlink.h)
> -CFLAGS_ovpn:=$(call get_hdr_inc,_LINUX_OVPN,ovpn.h)
> +CFLAGS_ovpn:=$(call get_hdr_inc,_LINUX_OVPN_H,ovpn.h)
>  CFLAGS_ovs_datapath:=$(call
> get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
>  CFLAGS_ovs_flow:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
>  CFLAGS_ovs_vport:=$(call
> get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
> --
> 2.49.0

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>