netdev - Re: [PATCH bpf-next/net] bpf: net_sched: Fix using bpf qdisc as default qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAl1tm5rwB0kq1/Y@pop-os.localdomain>
Date: Wed, 23 Apr 2025 16:20:22 -0700
From: Cong Wang <xiyou.wangcong@...il.com>
To: Amery Hung <ameryhung@...il.com>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org,
	alexei.starovoitov@...il.com, andrii@...nel.org,
	daniel@...earbox.net, martin.lau@...nel.org, kernel-team@...a.com
Subject: Re: [PATCH bpf-next/net] bpf: net_sched: Fix using bpf qdisc as
 default qdisc

On Tue, Apr 22, 2025 at 03:58:08PM -0700, Amery Hung wrote:
> Use bpf_try_module_get()/bpf_module_put() instead of try_module_get()/
> module_put() when handling default qdisc since users can assign a bpf
> qdisc to it.
> 
> To trigger the bug:
> $ bpftool struct_ops register bpf_qdisc_fq.bpf.o /sys/fs/bpf
> $ echo bpf_fq > /proc/sys/net/core/default_qdisc
> 

Good to see eBPF Qdisc's can be default as well.

> Fixes: c8240344956e (bpf: net_sched: Support implementation of Qdisc_ops in bpf)
> Signed-off-by: Amery Hung <ameryhung@...il.com>

Acked-by: Cong Wang <xiyou.wangcong@...il.com>

Thanks!