netdev - Re: [PATCH net-next v2 1/4] bnxt_en: Change FW message timeout warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e903cf91-6e88-45e7-a388-8b40c11ed45a@leemhuis.info>
Date: Wed, 23 Apr 2025 08:11:21 +0200
From: Thorsten Leemhuis <linux@...mhuis.info>
To: Louis Peens <louis.peens@...igine.com>,
 Michael Chan <michael.chan@...adcom.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, andrew+netdev@...n.ch,
 pavan.chebbi@...adcom.com, andrew.gospodarek@...adcom.com,
 Kalesh AP <kalesh-anakkur.purayil@...adcom.com>,
 Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH net-next v2 1/4] bnxt_en: Change FW message timeout
 warning

On 22.04.25 16:33, Louis Peens wrote:
> On Thu, Apr 17, 2025 at 10:24:45AM -0700, Michael Chan wrote:
>> The firmware advertises a "hwrm_cmd_max_timeout" value to the driver
>> for NVRAM and coredump related functions that can take tens of seconds
>> to complete.  The driver polls for the operation to complete under
>> mutex and may trigger hung task watchdog warning if the wait is too long.
>> To warn the user about this, the driver currently prints a warning if
>> this advertised value exceeds 40 seconds:
> 
> Hi. Sorry if this is noise - but I have not seen this reported yet. I
> think this change introduced a config dependency on 'DEBUG_KERNEL'. As far as I
> track the dependency chain:
> 
>     DEFAULT_HUNG_TASK_TIMEOUT -> DETECT_HUNG_TASK -> DEBUG_KERNEL.
> 
> I have a 'local_defconfig' file which I'm regularly using for compiles,
> and I had to add all three these CONFIG settings to it to be able to
> compile again, otherwise I encounter this issue:
> 
> drivers/net/ethernet/broadcom/bnxt/bnxt.c:10188:21: \
> error: 'CONFIG_DEFAULT_HUNG_TASK_TIMEOUT' undeclared (first use in this function)
>       max_tmo_secs > CONFIG_DEFAULT_HUNG_TASK_TIMEOUT) {
>                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Perhaps this was on purpose, but from what I can tell on a quick scan I don't
> think it was.

TWIMC, I yesterday ran into this myself with my daily -next builds for
Fedora, too. Log from the build can be found here:
https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-42-x86_64/08951548-next-next-all/builder-live.log.gz
Enabling DETECT_HUNG_TASK and DEFAULT_HUNG_TASK_TIMEOUT fixed it.

Randy (now CCed) reported the problem as well:
https://lore.kernel.org/all/8ba27b19-6259-49d3-a77f-84bfa39aa694@infradead.org/

Ciao, Thorsten