netdev - Re: [PATCH v2] leds: trigger: netdev: refactor dev matching in netdev_trig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250424080927.GC8734@google.com>
Date: Thu, 24 Apr 2025 09:09:27 +0100
From: Lee Jones <lee@...nel.org>
To: Tobias Junghans <tobias.junghans@...ub.de>
Cc: Andrew Lunn <andrew@...n.ch>, linux-leds@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH v2] leds: trigger: netdev: refactor dev matching in
 netdev_trig_notify()

On Wed, 23 Apr 2025, Tobias Junghans wrote:

> If there are network devices with the same name in different
> namespaces, ledtrig-netdev gets confused easily and switches between
> these devices whenever there are NETDEV_CHANGENAME/NETDEV_REGISTER
> notifications.  This happens since ledtrig-netdev only checks for
> device name equality regardless of previous associations with another
> network device with the same name.
> 
> Real world example: eth0 is the primary physical network interface and
> ledltrig-netdev is associated with that interface. If now Docker creates
> a virtual Ethernet interface (vethXXXX), moves it to the
> container's net namespace and renames it to eth0, ledtrig-netdev
> switches to this device and the LED no longer blinks for the original
> (physical) network device.
> 
> Fix this by refactoring the conditions under which to return early with
> NOTIFY_DONE inside netdev_trig_notify():
> 
> - For processing NETDEV_REGISTER events, the device name has to match
>   and no association with a net_dev must exist.
> 
> - For processing NETDEV_CHANGENAME events, the associated and notified
>   network device have to match. Alternatively the device name has to
>   match and no association with a net_dev must exist.
> 
> - For all other events, the associated and notified network device have
>   to match.
> 
> Signed-off-by: Tobias Junghans <tobias.junghans@...ub.de>
> ---
>  drivers/leds/trigger/ledtrig-netdev.c | 29 +++++++++++++++++++--------
>  1 file changed, 21 insertions(+), 8 deletions(-)

Please send subsequent versions independently, rather than attached to
the end of lengthy (or any for that matter) mail threads.  This gets
confusing, fast!

Also, this is v3.

Please resubmit.

-- 
Lee Jones [李琼斯]