netdev - Re: [PATCH v2 net-next 3/7] neighbour: Allocate skb in neigh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c932825f-6249-48c0-bb10-8c5754e01f8e@redhat.com>
Date: Thu, 24 Apr 2025 10:29:19 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>
Cc: Simon Horman <horms@...nel.org>, Kuniyuki Iwashima <kuni1840@...il.com>,
 netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 3/7] neighbour: Allocate skb in neigh_get().

On 4/18/25 3:26 AM, Kuniyuki Iwashima wrote:
> @@ -3013,23 +2982,30 @@ static int neigh_get(struct sk_buff *in_skb, struct nlmsghdr *nlh,
>  		pn = pneigh_lookup(tbl, net, dst, dev, 0);

pneigh_lookup() can create the neighbor when the last argument is 1, and
contains an ASSERT_RTNL() on such code path that may confuse the casual
reader. I think here you could use __pneigh_lookup().

Thanks,

Paolo