netdev - Re: [Intel-wired-lan] [PATCH iwl-next v4 2/2] igc: Change Tx mode for MQPRIO offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9d400f8e-e9c6-4c93-97ed-c891dc511825@intel.com>
Date: Thu, 24 Apr 2025 11:51:50 +0300
From: Mor Bar-Gabay <morx.bar.gabay@...el.com>
To: Kurt Kanzenbach <kurt@...utronix.de>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Faizal Rahim <faizal.abdul.rahim@...ux.intel.com>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Sebastian Andrzej Siewior
	<bigeasy@...utronix.de>, Simon Horman <horms@...nel.org>,
	<intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 2/2] igc: Change Tx mode for
 MQPRIO offloading

On 21/03/2025 15:52, Kurt Kanzenbach wrote:
> The current MQPRIO offload implementation uses the legacy TSN Tx mode. In
> this mode the hardware uses four packet buffers and considers queue
> priorities.
> 
> In order to harmonize the TAPRIO implementation with MQPRIO, switch to the
> regular TSN Tx mode. This mode also uses four packet buffers and considers
> queue priorities. In addition to the legacy mode, transmission is always
> coupled to Qbv. The driver already has mechanisms to use a dummy schedule
> of 1 second with all gates open for ETF. Simply use this for MQPRIO too.
> 
> This reduces code and makes it easier to add support for frame preemption
> later.
> 
> Tested on i225 with real time application using high priority queue, iperf3
> using low priority queue and network TAP device.
> 
> Acked-by: Faizal Rahim <faizal.abdul.rahim@...ux.intel.com>
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>
> Reviewed-by: Simon Horman <horms@...nel.org>
> ---
>   drivers/net/ethernet/intel/igc/igc.h     |  4 +---
>   drivers/net/ethernet/intel/igc/igc_tsn.c | 20 ++------------------
>   2 files changed, 3 insertions(+), 21 deletions(-)
> 
Tested-by: Mor Bar-Gabay <morx.bar.gabay@...el.com>