netdev - Re: [PATCH net-next V2 01/14] devlink: define enum for attr types of dynamic attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <djjwnxpqfcngooptb67pvelhdb4n53elnfgvq6wqjql2ss4egr@osfsq5ccs2tt>
Date: Thu, 24 Apr 2025 11:14:53 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Saeed Mahameed <saeed@...nel.org>, 
	"David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, 
	Eric Dumazet <edumazet@...gle.com>, Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org, 
	Tariq Toukan <tariqt@...dia.com>, Gal Pressman <gal@...dia.com>, Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next V2 01/14] devlink: define enum for attr types of
 dynamic attributes

Thu, Apr 24, 2025 at 12:07:35AM +0200, kuba@...nel.org wrote:
>On Wed, 23 Apr 2025 13:12:56 +0200 Jiri Pirko wrote:
>> >Coincidentally - you added it to the YNL spec but didn't set it for 
>> >the attrs that carry the values of the enum.  
>> 
>> True. Will drop it.
>
>Hm, drop it.. in? I mean you should set:
>
>	enum: your-enum-name
>
>on the param-type and .. fmsg-obj-value-type, I'm guessing?

Okay. Makes sense. Sorry for me being a bit slow here :)