netdev - Re: [PATCH v12 net-next 1/5] Documentation: netlink: specs: tc: Add DualPI2 specification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2wmb9syfc.fsf@gmail.com>
Date: Thu, 24 Apr 2025 10:26:15 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: "Chia-Yu Chang (Nokia)" <chia-yu.chang@...ia-bell-labs.com>
Cc: "xandfury@...il.com" <xandfury@...il.com>,  "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>,  "dave.taht@...il.com" <dave.taht@...il.com>,
  "pabeni@...hat.com" <pabeni@...hat.com>,  "jhs@...atatu.com"
 <jhs@...atatu.com>,  "kuba@...nel.org" <kuba@...nel.org>,
  "stephen@...workplumber.org" <stephen@...workplumber.org>,
  "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
  "jiri@...nulli.us" <jiri@...nulli.us>,  "davem@...emloft.net"
 <davem@...emloft.net>,  "edumazet@...gle.com" <edumazet@...gle.com>,
  "horms@...nel.org" <horms@...nel.org>,  "andrew+netdev@...n.ch"
 <andrew+netdev@...n.ch>,  "ast@...erby.net" <ast@...erby.net>,
  "liuhangbin@...il.com" <liuhangbin@...il.com>,  "shuah@...nel.org"
 <shuah@...nel.org>,  "linux-kselftest@...r.kernel.org"
 <linux-kselftest@...r.kernel.org>,  "ij@...nel.org" <ij@...nel.org>,
  "ncardwell@...gle.com" <ncardwell@...gle.com>,  "Koen De Schepper
 (Nokia)" <koen.de_schepper@...ia-bell-labs.com>,  g.white
 <g.white@...lelabs.com>,  "ingemar.s.johansson@...csson.com"
 <ingemar.s.johansson@...csson.com>,  "mirja.kuehlewind@...csson.com"
 <mirja.kuehlewind@...csson.com>,  "cheshire@...le.com"
 <cheshire@...le.com>,  "rs.ietf@....at" <rs.ietf@....at>,
  "Jason_Livingood@...cast.com" <Jason_Livingood@...cast.com>,  vidhi_goel
 <vidhi_goel@...le.com>
Subject: Re: [PATCH v12 net-next 1/5] Documentation: netlink: specs: tc: Add
 DualPI2 specification

"Chia-Yu Chang (Nokia)" <chia-yu.chang@...ia-bell-labs.com> writes:

>> The syntax is not valid so this doesn't pass the schema check and presumably hasn't been tested. Please validate YNL .yaml additions e.g.
>> 
>> ./tools/net/ynl/pyynl/cli.py \
>>     --spec Documentation/netlink/specs/tc.yaml \
>>     --list-ops
>> 
>> ...
>> jsonschema.exceptions.ValidationError: Additional properties are not allowed ('entries' was unexpected) ...
>> On instance['attribute-sets'][30]['attributes'][14]:
>>     {'name': 'gso_split',
>>      'type': 'flags',
>>      'doc': 'Split aggregated skb or not',
>>      'entries': ['split_gso', 'no_split_gso']}
>> 
>
> Hi Donald,
>
> 	Thanks for the feedback, and I will take actions for below points as well as the corresponding iproute2-net fixes.
> 	One more question is I see "uint" type is not valid during validation - see below (but which was suggested in v11), shall I change it back to u32/u8?
>
> Failed validating 'enum' in schema['properties']['definitions']['items']['properties']['members']['items']['properties']['type']:
>     {'description': "The netlink attribute type. Members of type 'binary' "
>                     "or 'pad'\n"
>                     "must also have the 'len' property set.\n",
>      'enum': ['u8',
>               'u16',
>               'u32',
>               'u64',
>               's8',
>               's16',
>               's32',
>               's64',
>               'string',
>               'binary',
>               'pad']}
>
> On instance['definitions'][42]['members'][12]['type']:
>     'uint'	

The advice from Paolo was a bit misleading. It is correct for netlink
attributes which support variable size scalars, but not for struct
members which must be a fixed size.

So for tc-dualpi2-xstats, the member types must match the struct
tc_dualpi2_xstats types.