netdev - Re: [net-next,v2] net: phy: marvell-88q2xxx: Enable temperature sensor for mv88q211x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9ccea14-04c1-4f5a-8b55-b6f9166289ab@redhat.com>
Date: Thu, 24 Apr 2025 13:19:25 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Heiner Kallweit <hkallweit1@...il.com>,
 Niklas Söderlund <niklas.soderlund+renesas@...natech.se>,
 Andrew Lunn <andrew@...n.ch>, Russell King <linux@...linux.org.uk>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Dimitri Fedrau <dima.fedrau@...il.com>,
 netdev@...r.kernel.org
Cc: linux-renesas-soc@...r.kernel.org
Subject: Re: [net-next,v2] net: phy: marvell-88q2xxx: Enable temperature
 sensor for mv88q211x

On 4/18/25 6:10 PM, Heiner Kallweit wrote:
> On 18.04.2025 16:58, Niklas Söderlund wrote:
>> The temperature sensor enabled for mv88q222x devices also functions for
>> mv88q211x based devices. Unify the two devices probe functions to enable
>> the sensors for all devices supported by this driver.
>>
>> The same oddity as for mv88q222x devices exists, the PHY link must be up
>> for a correct temperature reading to be reported.
>>
>>     # cat /sys/class/hwmon/hwmon9/temp1_input
>>     -75000
>>
>>     # ifconfig end5 up
>>
>>     # cat /sys/class/hwmon/hwmon9/temp1_input
>>     59000
>>
>> Worth noting is that while the temperature register offsets and layout
>> are the same between mv88q211x and mv88q222x devices their names in the
>> datasheets are different. This change keeps the mv88q222x names for the
>> mv88q211x support.
>>
>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
>> Reviewed-by: Dimitri Fedrau <dima.fedrau@...il.com>
>> ---
>> * Changes since v1
>> - Clarify in commit message that it's the link that must be up for the
>>   reporting to work, not just power up. Hopefully this oddity can be
>>   solved in the future by patch [1].
>>
> Following this link I don't see anything which would deal with incorrect
> values being shown if link is down. What are you referring to in detail?
> I think you have to modify mv88q2xxx_hwmon_is_visible(), or return an
> appropriate error in mv88q2xxx_hwmon_read() if link is down.

@Heiner: my take is that the temp reading oddity should/will be handled
in a separate (net) patch, let's not block this patch due to that.

Thanks,

Paolo