netdev - [PATCH net-next v1 0/4] Improve EEE control for KSZ switches and clarify ethtool output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250424130222.3959457-1-o.rempel@pengutronix.de>
Date: Thu, 24 Apr 2025 15:02:18 +0200
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Woojung Huh <woojung.huh@...rochip.com>,
	Andrew Lunn <andrew@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>,
	kernel@...gutronix.de,
	linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org,
	UNGLinuxDriver@...rochip.com,
	Simon Horman <horms@...nel.org>,
	Maxime Chevallier <maxime.chevallier@...tlin.com>
Subject: [PATCH net-next v1 0/4]  Improve EEE control for KSZ switches and clarify ethtool output

This patch series addresses two areas related to Energy Efficient
Ethernet (EEE) handling, focusing on better integration of Microchip KSZ
switches with the DSA framework and improving the clarity of ethtool
--show-eee output.

Part 1: Previously, I added a filter to the set_mac_eee() implementation
in the Microchip KSZ driver to reject unsupported configurations -
specifically, attempts to disable LPI while keeping EEE enabled, or to
change the Tx LPI timer. This was intended as a safeguard to clarify
what the driver does not support, since EEE is handled internally by the
KSZ hardware through PHY advertisement.

However, after many changes in the EEE framework, this filter has become
outdated and problematic. It now blocks users from disabling EEE
altogether. Since there is no MAC-level configuration required for KSZ
switches, and the driver already implements support_eee(), the cleanest
path forward is to remove the set_mac_eee() implementation entirely.

Part 2: Clarify ethtool output related to EEE
The ethtool --show-eee command could produce misleading output:
- It displayed "Advertised EEE link modes" even when EEE was disabled
- It omitted the link partner's EEE advertisement unless local EEE was
  enabled

The remaining patches focus on improving the usability and correctness
of the ethtool --show-eee output, particularly in cases where EEE is
disabled.

Tested with Microchip KSZ series hardware.

Oleksij Rempel (4):
  net: dsa: user: Skip set_mac_eee() if support_eee() is implemented
  net: dsa: microchip: Remove set_mac_eee() callback from KSZ driver
  net: phy: Don't report advertised EEE modes if EEE is disabled
  net: phy: Always read EEE LPA in genphy_c45_ethtool_get_eee()

 drivers/net/dsa/microchip/ksz_common.c | 19 -------------------
 drivers/net/phy/phy-c45.c              |  7 ++++---
 net/dsa/user.c                         |  6 ++----
 3 files changed, 6 insertions(+), 26 deletions(-)

--
2.39.5