netdev - Re: [PATCH net-next 01/12] tools: ynl-gen: fix comment about nested struct dict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65235ebc-17c0-46e2-a684-19870b9fb99c@intel.com>
Date: Thu, 24 Apr 2025 08:40:46 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<andrew+netdev@...n.ch>, <horms@...nel.org>, <donald.hunter@...il.com>,
	<sdf@...ichev.me>
Subject: Re: [PATCH net-next 01/12] tools: ynl-gen: fix comment about nested
 struct dict



On 4/23/2025 7:11 PM, Jakub Kicinski wrote:
> The dict stores struct objects (of class Struct), not just
> a trivial set with directions.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  tools/net/ynl/pyynl/ynl_gen_c.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen_c.py
> index 9613a6135003..077aacd5f33a 100755
> --- a/tools/net/ynl/pyynl/ynl_gen_c.py
> +++ b/tools/net/ynl/pyynl/ynl_gen_c.py
> @@ -1015,7 +1015,7 @@ from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, S
>  
>          # dict space-name -> 'request': set(attrs), 'reply': set(attrs)
>          self.root_sets = dict()
> -        # dict space-name -> set('request', 'reply')
> +        # dict space-name -> Struct
>          self.pure_nested_structs = dict()
>  
>          self._mark_notify()