netdev - Re: [PATCH net-next 06/12] tools: ynl-gen: support CRUD-like notifications for classic Netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e91e02c-b7df-431b-b4a6-2c5bbac407da@intel.com>
Date: Thu, 24 Apr 2025 08:52:37 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<andrew+netdev@...n.ch>, <horms@...nel.org>, <donald.hunter@...il.com>,
	<sdf@...ichev.me>
Subject: Re: [PATCH net-next 06/12] tools: ynl-gen: support CRUD-like
 notifications for classic Netlink



On 4/23/2025 7:12 PM, Jakub Kicinski wrote:
> Allow CRUD-style notification where the notification is more
> like the response to the request, which can optionally be
> looped back onto the requesting socket. Since the notification
> and request are different ops in the spec, for example:
> 
>     -
>       name: delrule
>       doc: Remove an existing FIB rule
>       attribute-set: fib-rule-attrs
>       do:
>         request:
>           value: 33
>           attributes: *fib-rule-all
>     -
>       name: delrule-ntf
>       doc: Notify a rule deletion
>       value: 33
>       notify: getrule
> 
> We need to find the request by ID. Ideally we'd detect this model
> from the spec properties, rather than assume that its what all
> classic netlink families do. But maybe that'd cause this model
> to spread and its easy to get wrong. For now assume CRUD == classic.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

> ---
>  tools/net/ynl/pyynl/ynl_gen_c.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/net/ynl/pyynl/ynl_gen_c.py b/tools/net/ynl/pyynl/ynl_gen_c.py
> index 2999a2953595..6e697d800875 100755
> --- a/tools/net/ynl/pyynl/ynl_gen_c.py
> +++ b/tools/net/ynl/pyynl/ynl_gen_c.py
> @@ -2789,7 +2789,11 @@ _C_KW = {
>  
>  
>  def _render_user_ntf_entry(ri, op):
> -    ri.cw.block_start(line=f"[{op.enum_name}] = ")
> +    if not ri.family.is_classic():
> +        ri.cw.block_start(line=f"[{op.enum_name}] = ")
> +    else:
> +        crud_op = ri.family.req_by_value[op.rsp_value]
> +        ri.cw.block_start(line=f"[{crud_op.enum_name}] = ")
>      ri.cw.p(f".alloc_sz\t= sizeof({type_name(ri, 'event')}),")
>      ri.cw.p(f".cb\t\t= {op_prefix(ri, 'reply', deref=True)}_parse,")
>      ri.cw.p(f".policy\t\t= &{ri.struct['reply'].render_name}_nest,")