netdev - Re: [PATCH 0/4] selftest: can: Start importing selftests from can-tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZ6RqK8TdzzMW645OLq5tbkyQdYW+tGGVcr7vsRBE81_u4W4Q@mail.gmail.com>
Date: Thu, 24 Apr 2025 16:45:41 +0900
From: Vincent Mailhol <mailhol.vincent@...adoo.fr>
To: Felix Maurer <fmaurer@...hat.com>
Cc: socketcan@...tkopp.net, mkl@...gutronix.de, shuah@...nel.org, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	horms@...nel.org, linux-can@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kselftest@...r.kernel.org, dcaratti@...hat.com, fstornio@...hat.com
Subject: Re: [PATCH 0/4] selftest: can: Start importing selftests from can-tests

Hi Felix,

On Tue. 22 Apr. 2025 at 21:08, Felix Maurer <fmaurer@...hat.com> wrote:
> This is the initial import of a CAN selftest from can-tests[1] into the
> tree. For now, it is just a single test but when agreed on the
> structure, we intend to import more tests from can-tests and add
> additional test cases.

Excellent initiative!

> The goal of moving the CAN selftests into the tree is to align the tests
> more closely with the kernel, improve testing of CAN in general, and to
> simplify running the tests automatically in the various kernel CI
> systems.
>
> I have cc'ed netdev and its reviewers and maintainers to make sure they
> are okay with the location of the tests and the changes to the paths in
> MAINTAINERS. The changes should be merged through linux-can-next and
> subsequent changes will not go to netdev anymore.

I am not a netdev maintainer, just a /drivers/net/can maintainer, but
you have my blessing on this. As far the location goes, your proposal
makes perfect sense to me. Actually, I can not think of any other
places than

  tools/testing/selftests/net/can

for this kind of thing.

> [1]: https://github.com/linux-can/can-tests
>
> Felix Maurer (4):
>   selftests: can: Import tst-filter from can-tests
>   selftests: can: use kselftest harness in test_raw_filter
>   selftests: can: Use fixtures in test_raw_filter
>   selftests: can: Document test_raw_filter test cases

You are doing a lot of change to the original to the point that this
is more a full rewrite. I have no intent of reviewing the first patch
which is just the copy paste from the original. If no one else has a
strong opinion on this, I would rather prefer if you just squash
everything and send a single patch with the final result. This will
also save you some effort when migrating the other tests.

I have a few comments on the individual patches, but overall very
good. Thanks a lot!


Yours sincerely,
Vincent Mailhol