netdev - Re: [PATCH net 1/5] net: vertexcom: mse102x: Fix possible stuck of SPI interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e261db8-7b3a-4425-93ce-b7bac3746da1@gmx.net>
Date: Fri, 25 Apr 2025 09:35:04 +0200
From: Stefan Wahren <wahrenst@....net>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, netdev@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH net 1/5] net: vertexcom: mse102x: Fix possible stuck of
 SPI interrupt

Hi Jakub,

Am 25.04.25 um 03:18 schrieb Jakub Kicinski:
> On Wed, 23 Apr 2025 09:45:49 +0200 Stefan Wahren wrote:
>> The MSE102x doesn't provide any SPI commands for interrupt handling.
>> So in case the interrupt fired before the driver requests the IRQ,
>> the interrupt will never fire again. In order to fix this always poll
>> for pending packets after opening the interface.
> Wouldn't this cause invalid_rts or some other error counter
> to increment every time the user opens the device?
you are right, this would increase the invalid_cmd counter.

I'm missed to mention in the cover letter, that this series is only the 
first part of two patch series. The first one only contains fixes, which 
should be backported. The second one contains improvement, which can go 
to net-next.

Regarding the invalid_cmd there is already a patch in my backlog, but I 
didn't consider this as a real fix:

net: vertexcom: mse102x: drop invalid cmd stats

Since the SPI implementation on the MSE102x MCU is in software, it 
cannot reply to SPI commands in busy state. So drop the scaring 
statistics about "invalid" command replies.

https://github.com/chargebyte/linux/commit/9f8a69e5c0d6c4482e89d7b86f72069b89a94547

Should I add it as a fix?

Regards