netdev - Re: [PATCH net-next 11/12] tools: ynl-gen: don't init enum checks for classic netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250424193630.2a195593@kernel.org>
Date: Thu, 24 Apr 2025 19:36:30 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jacob Keller <jacob.e.keller@...el.com>
Cc: <davem@...emloft.net>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <andrew+netdev@...n.ch>, <horms@...nel.org>,
 <donald.hunter@...il.com>, <sdf@...ichev.me>
Subject: Re: [PATCH net-next 11/12] tools: ynl-gen: don't init enum checks
 for classic netlink

On Thu, 24 Apr 2025 08:59:45 -0700 Jacob Keller wrote:
> > +        if not family.is_classic():
> > +            # Classic families have some funny enums, don't bother
> > +            # computing checks we only need them for policy
> > +            self._init_checks()
> >    
> 
> I feel like having the comment inside the if block was a bit misleading
> since its talking about skipping the checks, but this is the control
> flow where we *don't* skip the checks. I guess thats a bit of taste as
> to whether this makes sense to go before the if check or not.

Fair, will move