netdev - Re: [PATCH net-next v1 3/3] io_uring/zcrx: selftests: add test case for rss ctx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe560d8d-a331-48ab-a450-5a43bf76be67@davidwei.uk>
Date: Fri, 25 Apr 2025 16:38:16 -0700
From: David Wei <dw@...idwei.uk>
To: Joe Damato <jdamato@...tly.com>, netdev@...r.kernel.org,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v1 3/3] io_uring/zcrx: selftests: add test case
 for rss ctx

On 2025-04-25 15:55, Joe Damato wrote:
> On Thu, Apr 24, 2025 at 07:20:49PM -0700, David Wei wrote:
>> RSS contexts are used to shard work across multiple queues for an
>> application using io_uring zero copy receive. Add a test case checking
>> that steering flows into an RSS context works.
>>
>> Until I add multi-thread support to the selftest binary, this test case
>> only has 1 queue in the RSS context.
>>
>> Signed-off-by: David Wei <dw@...idwei.uk>
>> ---
>>  .../selftests/drivers/net/hw/iou-zcrx.py      | 41 +++++++++++++++++++
>>  1 file changed, 41 insertions(+)
>>
>> diff --git a/tools/testing/selftests/drivers/net/hw/iou-zcrx.py b/tools/testing/selftests/drivers/net/hw/iou-zcrx.py
>> index 0b0b6a261159..48b3d27cf472 100755
>> --- a/tools/testing/selftests/drivers/net/hw/iou-zcrx.py
>> +++ b/tools/testing/selftests/drivers/net/hw/iou-zcrx.py
>> @@ -21,12 +21,25 @@ def _get_combined_channels(cfg):
>>      return int(values[1])
>>  
>>  
>> +    output = ethtool(f"-N {cfg.ifname} flow-type tcp6 dst-port 9999 action {chan}", host=cfg.remote).stdout
>> +    rx_cmd = f"{cfg.bin_remote} -s -p 9999 -i {cfg.ifname} -q {combined_chans - 1}"
>> +    tx_cmd = f"{cfg.bin_local} -c -h {cfg.remote_addr_v['6']} -p 9999 -l 12840"
> 
> I wonder if perhaps future cleanup work might use rand_port from
> lib.py instead of hardcoding 9999 ?

SG, I'll tackle this as a follow up.

> 
> Reviewed-by: Joe Damato <jdamato@...tly.com>