netdev - Re: [PATCH net v2 3/3] idpf: fix offloads support for encapsulated packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <680cf3f899896_193a062945f@willemb.c.googlers.com.notmuch>
Date: Sat, 26 Apr 2025 10:55:52 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>, 
 davem@...emloft.net, 
 kuba@...nel.org, 
 pabeni@...hat.com, 
 edumazet@...gle.com, 
 andrew+netdev@...n.ch, 
 netdev@...r.kernel.org
Cc: Madhu Chittim <madhu.chittim@...el.com>, 
 anthony.l.nguyen@...el.com, 
 willemb@...gle.com, 
 Sridhar Samudrala <sridhar.samudrala@...el.com>, 
 Zachary Goldstein <zachmgoldstein@...gle.com>, 
 Samuel Salin <Samuel.salin@...el.com>
Subject: Re: [PATCH net v2 3/3] idpf: fix offloads support for encapsulated
 packets

Tony Nguyen wrote:
> From: Madhu Chittim <madhu.chittim@...el.com>
> 
> Split offloads into csum, tso and other offloads so that tunneled
> packets do not by default have all the offloads enabled.
> 
> Stateless offloads for encapsulated packets are not yet supported in
> firmware/software but in the driver we were setting the features same as
> non encapsulated features.
> 
> Fixed naming to clarify CSUM bits are being checked for Tx.
> 
> Inherit netdev features to VLAN interfaces as well.
> 
> Fixes: 0fe45467a104 ("idpf: add create vport and netdev configuration")
> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
> Signed-off-by: Madhu Chittim <madhu.chittim@...el.com>
> Tested-by: Zachary Goldstein <zachmgoldstein@...gle.com>
> Tested-by: Samuel Salin <Samuel.salin@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

The issue resolved was that checksum offload support was advertised
for tunneled packets, but not implemented in (some) firmware.

Support for tunnel encap without checksum offload (e.g., plain GRE)
and even GSO_PARTIAL may still work. Not sure. If so, that can be
reenabled at a later date.