netdev - Re: [PATCH net-next v5] Add support to set napi threaded for individual napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250425173743.04effd75@kernel.org>
Date: Fri, 25 Apr 2025 17:37:43 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Samiullah Khawaja <skhawaja@...gle.com>
Cc: Joe Damato <jdamato@...tly.com>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, almasrymina@...gle.com, willemb@...gle.com,
 mkarsten@...terloo.ca, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5] Add support to set napi threaded for
 individual napi

On Fri, 25 Apr 2025 15:52:30 -0700 Samiullah Khawaja wrote:
> > Probably need a maintainer to weigh-in on what the preferred
> > behavior is. Maybe there's a reason the thread isn't killed.  
> +1
> 
> I think the reason behind it not being killed is because the user
> might have already done some configuration using the PID and if the
> kthread was removed, the user would have to do that configuration
> again after enable/disable. But I am just speculating. I will let the
> maintainers weigh-in as you suggested.

I haven't looked at the code, but I think it may be something more
trivial, namely that napi_enable() return void, so it can't fail.
Also it may be called under a spin lock.