netdev - Re: [PATCH iwl-net] iavf: fix reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250428124422.GB3339421@horms.kernel.org>
Date: Mon, 28 Apr 2025 13:44:22 +0100
From: Simon Horman <horms@...nel.org>
To: Marcin Szycik <marcin.szycik@...ux.intel.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	Ahmed Zaki <ahmed.zaki@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH iwl-net] iavf: fix reset_task for early reset event

On Thu, Apr 24, 2025 at 03:50:13PM +0200, Marcin Szycik wrote:
> From: Ahmed Zaki <ahmed.zaki@...el.com>
> 
> If a reset event is received from the PF early in the init cycle, the
> state machine hangs for about 25 seconds.
> 
> Reproducer:
>   echo 1 > /sys/class/net/$PF0/device/sriov_numvfs
>   ip link set dev $PF0 vf 0 mac $NEW_MAC
> 
> The log shows:
>   [792.620416] ice 0000:5e:00.0: Enabling 1 VFs
>   [792.738812] iavf 0000:5e:01.0: enabling device (0000 -> 0002)
>   [792.744182] ice 0000:5e:00.0: Enabling 1 VFs with 17 vectors and 16 queues per VF
>   [792.839964] ice 0000:5e:00.0: Setting MAC 52:54:00:00:00:11 on VF 0. VF driver will be reinitialized
>   [813.389684] iavf 0000:5e:01.0: Failed to communicate with PF; waiting before retry
>   [818.635918] iavf 0000:5e:01.0: Hardware came out of reset. Attempting reinit.
>   [818.766273] iavf 0000:5e:01.0: Multiqueue Enabled: Queue pair count = 16
> 
> Fix it by scheduling the reset task and making the reset task capable of
> resetting early in the init cycle.
> 
> Fixes: ef8693eb90ae3 ("i40evf: refactor reset handling")
> Signed-off-by: Ahmed Zaki <ahmed.zaki@...el.com>
> Tested-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Marcin Szycik <marcin.szycik@...ux.intel.com>
> ---
> This should be applied after "iavf: get rid of the crit lock"

Reviewed-by: Simon Horman <horms@...nel.org>