netdev - Re: [PATCH net-next v3 2/3] devlink: add function unique identifier to devlink dev info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250428111252.62d4309c@kernel.org>
Date: Mon, 28 Apr 2025 11:12:52 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, tariqt@...dia.com, andrew+netdev@...n.ch,
 horms@...nel.org, donald.hunter@...il.com,
 kalesh-anakkur.purayil@...adcom.com
Subject: Re: [PATCH net-next v3 2/3] devlink: add function unique identifier
 to devlink dev info

On Mon, 28 Apr 2025 18:28:24 +0200 Jiri Pirko wrote:
> >You just need to find a better place to expose the client side.  
> 
> Okay. Why exactly you find it wrong to put it under devlink dev info?
> I mean, to me it is perfect fit. It is basically another serial number,
> uniqueue identification of devlink device.
> 
> If other place is better fit, I don't see it.

devlink instance should represent the device, not a PF / port;
and then having the attribute on the instance does not fit
an eswitch controller with 2 PFs connected.

> Do you have some ideas?

Either subsystem specific (like a netdev attr) or not subsystem
specific (bus dev attr, so PCI). Forcing every endpoint to expose
a devlink instance just for one attribute is too much of a hack.