netdev - Re: [PATCH net-next] netlink: specs: ethtool: Remove UAPI duplication of phy-upstream enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250428155119.386e62c8@kernel.org>
Date: Mon, 28 Apr 2025 15:51:19 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Maxime Chevallier
 <maxime.chevallier@...tlin.com>, thomas.petazzoni@...tlin.com, Andrew Lunn
 <andrew@...n.ch>, Donald Hunter <donald.hunter@...il.com>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next] netlink: specs: ethtool: Remove UAPI
 duplication of phy-upstream enum

On Fri, 25 Apr 2025 19:14:18 +0200 Kory Maincent wrote:
> The phy-upstream enum is already defined in the ethtool.h UAPI header
> and used by the ethtool userspace tool. However, the ethtool spec does
> not reference it, causing YNL to auto-generate a duplicate and redundant
> enum.
> 
> Fix this by updating the spec to reference the existing UAPI enum
> in ethtool.h.
> 
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
> ---
> Not sure if it should be sent as a fix as there is no real issue here.

Indeed, but better deliver it to users ASAP otherwise some app 
may start using this unnecessary enum.