[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <772474665.1172924.1745921020429.JavaMail.zimbra@couthit.local>
Date: Tue, 29 Apr 2025 15:33:40 +0530 (IST)
From: Parvathi Pudi <parvathi@...thit.com>
To: kuba <kuba@...nel.org>
Cc: parvathi <parvathi@...thit.com>, danishanwar <danishanwar@...com>,
rogerq <rogerq@...nel.org>, andrew+netdev <andrew+netdev@...n.ch>,
davem <davem@...emloft.net>, edumazet <edumazet@...gle.com>,
pabeni <pabeni@...hat.com>, robh <robh@...nel.org>,
krzk+dt <krzk+dt@...nel.org>, conor+dt <conor+dt@...nel.org>,
nm <nm@...com>, ssantosh <ssantosh@...nel.org>,
tony <tony@...mide.com>, richardcochran <richardcochran@...il.com>,
glaroque <glaroque@...libre.com>, schnelle <schnelle@...ux.ibm.com>,
m-karicheri2 <m-karicheri2@...com>, s hauer <s.hauer@...gutronix.de>,
rdunlap <rdunlap@...radead.org>, diogo ivo <diogo.ivo@...mens.com>,
basharath <basharath@...thit.com>, horms <horms@...nel.org>,
jacob e keller <jacob.e.keller@...el.com>,
m-malladi <m-malladi@...com>,
javier carrasco cruz <javier.carrasco.cruz@...il.com>,
afd <afd@...com>, s-anna <s-anna@...com>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
netdev <netdev@...r.kernel.org>,
devicetree <devicetree@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
pratheesh <pratheesh@...com>, Prajith Jayarajan <prajith@...com>,
Vignesh Raghavendra <vigneshr@...com>, praneeth <praneeth@...com>,
srk <srk@...com>, rogerq <rogerq@...com>,
krishna <krishna@...thit.com>, pmohan <pmohan@...thit.com>,
mohan <mohan@...thit.com>
Subject: Re: [PATCH net-next v6 04/11] net: ti: prueth: Adds link detection,
RX and TX support.
Hi,
> On Wed, 23 Apr 2025 12:53:49 +0530 Parvathi Pudi wrote:
>> +static inline void icssm_prueth_write_reg(struct prueth *prueth,
>> + enum prueth_mem region,
>> + unsigned int reg, u32 val)
>> +{
>> + writel_relaxed(val, prueth->mem[region].va + reg);
>> +}
>
> Please don't use "inline" unnecessarily.
> The compiler will inline a single-line static function.
Understood. We will address this in the next version.
Thanks and Regards,
Parvathi.
Powered by blists - more mailing lists