netdev - Re: [PATCH net-next 1/2] dt-bindings: net: ethernet-phy: remove eee-broken flags which have never had a user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqJYmnk+ApfC1mxjMxCWFoedn1-XCKHS7Tq_gsgOTnx2Fg@mail.gmail.com>
Date: Tue, 29 Apr 2025 10:13:51 -0500
From: Rob Herring <robh@...nel.org>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, Andrew Lunn <andrew@...n.ch>, 
	Russell King - ARM Linux <linux@...linux.org.uk>, Paolo Abeni <pabeni@...hat.com>, 
	Eric Dumazet <edumazet@...gle.com>, David Miller <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Florian Fainelli <f.fainelli@...il.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: ethernet-phy: remove
 eee-broken flags which have never had a user

On Mon, Apr 28, 2025 at 3:28 PM Heiner Kallweit <hkallweit1@...il.com> wrote:
>
> On 28.04.2025 09:42, Krzysztof Kozlowski wrote:
> > On Tue, Apr 15, 2025 at 09:55:55PM GMT, Heiner Kallweit wrote:
> >> These flags have never had a user, so remove support for them.
> >
> > They have no in-kernel user, but what about all out of tree users in
> > kernel and other projects using bindings?
> >
> I doubt there's any user outside the kernel. But it's hard to prove
> that something does not exist. For my understanding:
> What would be the needed proof to consider removal of these
> flag bindings safe?

Like you say, you can't prove it. So your justification in the commit
msg isn't fact. I think if there was some pain to keep them, then
removing them and seeing if anyone complains would be fine.

It's not clear to me here why "eee-broken-1000t" is still valid/useful
when the others are not.

Rob