netdev - Re: [PATCH v2] net: rds: Replace strncpy with strscpy in connection setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250429110919.37ceacce@kernel.org>
Date: Tue, 29 Apr 2025 11:09:19 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Shankari Anand <shankari.ak0208@...il.com>
Cc: netdev@...r.kernel.org, allison.henderson@...cle.com,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 horms@...nel.org, shuah@...nel.org
Subject: Re: [PATCH v2] net: rds: Replace strncpy with strscpy in connection
 setup

On Sun, 27 Apr 2025 00:51:13 +0530 Shankari Anand wrote:
> From: Shankari02 <shankari.ak0208@...il.com>

Not your full name, the last From: in the email is what matters.
Maybe try to correct the author of the commit in your git tree.

> This patch replaces strncpy() with strscpy(), which is the preferred, safer
> alternative for bounded string copying in the Linux kernel. strscpy() guarantees
> null-termination as long as the destination buffer is non-zero in size and provides
> a return value to detect truncation.

Please wrap the commit message at 72 chars.

> Padding of the 'transport' field is not necessary because it is treated purely
> as a null-terminated string and is not used for binary comparisons or direct
> memory operations that would rely on padding. Therefore, switching to strscpy()
> is safe and appropriate here.

It's treated as purely null-terminated string? Where exactly
in the code do you see that? Because all I see is a memcpy..