netdev - Re: [PATCH net-next v2 10/11] idpf: add Tx timestamp flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40f89f87-0590-433c-b490-95ecc5f50435@intel.com>
Date: Tue, 29 Apr 2025 13:06:52 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>
CC: <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<andrew+netdev@...n.ch>, <netdev@...r.kernel.org>, Milena Olech
	<milena.olech@...el.com>, <przemyslaw.kitszel@...el.com>,
	<richardcochran@...il.com>, Josh Hay <joshua.a.hay@...el.com>, Samuel Salin
	<Samuel.salin@...el.com>
Subject: Re: [PATCH net-next v2 10/11] idpf: add Tx timestamp flows



On 4/28/2025 5:37 PM, Jakub Kicinski wrote:
> On Fri, 25 Apr 2025 14:52:24 -0700 Tony Nguyen wrote:
>> @@ -479,6 +480,9 @@ static const struct idpf_stats idpf_gstrings_port_stats[] = {
>>  	IDPF_PORT_STAT("tx-unicast_pkts", port_stats.vport_stats.tx_unicast),
>>  	IDPF_PORT_STAT("tx-multicast_pkts", port_stats.vport_stats.tx_multicast),
>>  	IDPF_PORT_STAT("tx-broadcast_pkts", port_stats.vport_stats.tx_broadcast),
>> +	IDPF_PORT_STAT("tx-hwtstamp_skipped", port_stats.tx_hwtstamp_skipped),
>> +	IDPF_PORT_STAT("tx-hwtstamp_flushed", tstamp_stats.tx_hwtstamp_flushed),
>> +	IDPF_PORT_STAT("tx-hwtstamp_discarded", tstamp_stats.tx_hwtstamp_discarded),
>>  };
> 
> I don't see the implementation of the standard stats via get_ts_stats
> You must implement standard stats before exposing custom breakdown.

Good point. I missed that during my review.

Thanks,
Jake