netdev - Re: [PATCH net-next v2] net: dlink: add synchronization for stats update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250429143503.5a44a94f@kernel.org>
Date: Tue, 29 Apr 2025 14:35:03 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Moon Yeounsu <yyyynoom@...il.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: dlink: add synchronization for stats
 update

On Sat, 26 Apr 2025 08:13:52 +0900 Moon Yeounsu wrote:
> +	spin_lock_irq(&np->stats_lock);
>  	/* Maximum Collisions */
>  	if (tx_status & 0x08)
>  		dev->stats.collisions++;
> +
> +	dev->stats.tx_errors++;
> +	spin_unlock_irq(&np->stats_lock);

I could be wrong but since this code runs in IRQ context I believe 
you need to use spin_lock_irqsave() here. Or just spin_lock() but
not sure, and spin_lock_irqsave() always works..
-- 
pw-bot: cr