netdev - Re: [PATCH v1 net-next] ipv6: Restore fib6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202504300946.ZH4g32Gw-lkp@intel.com>
Date: Wed, 30 Apr 2025 09:59:01 +0800
From: kernel test robot <lkp@...el.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
	"David S. Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	netdev@...r.kernel.org, Simon Horman <horms@...nel.org>,
	Kuniyuki Iwashima <kuniyu@...zon.com>,
	syzkaller <syzkaller@...glegroups.com>,
	Yi Lai <yi1.lai@...ux.intel.com>
Subject: Re: [PATCH v1 net-next] ipv6: Restore fib6_config validation for
 SIOCADDRT.

Hi Kuniyuki,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/ipv6-Restore-fib6_config-validation-for-SIOCADDRT/20250429-094825
base:   net-next/main
patch link:    https://lore.kernel.org/r/20250429014624.61938-1-kuniyu%40amazon.com
patch subject: [PATCH v1 net-next] ipv6: Restore fib6_config validation for SIOCADDRT.
config: s390-randconfig-001-20250430 (https://download.01.org/0day-ci/archive/20250430/202504300946.ZH4g32Gw-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250430/202504300946.ZH4g32Gw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504300946.ZH4g32Gw-lkp@intel.com/

All errors (new ones prefixed by >>):

>> net/ipv6/route.c:5715:29: error: passing 'struct fib6_config' to parameter of incompatible type 'struct fib6_config *'; take the address with &
    5715 |         err = fib6_config_validate(cfg, extack);
         |                                    ^~~
         |                                    &
   net/ipv6/route.c:4499:53: note: passing argument to parameter 'cfg' here
    4499 | static int fib6_config_validate(struct fib6_config *cfg,
         |                                                     ^
   1 error generated.

vim +5715 net/ipv6/route.c

  5704	
  5705	static int inet6_rtm_newroute(struct sk_buff *skb, struct nlmsghdr *nlh,
  5706				      struct netlink_ext_ack *extack)
  5707	{
  5708		struct fib6_config cfg;
  5709		int err;
  5710	
  5711		err = rtm_to_fib6_config(skb, nlh, &cfg, extack);
  5712		if (err < 0)
  5713			return err;
  5714	
> 5715		err = fib6_config_validate(cfg, extack);
  5716		if (err)
  5717			return err;
  5718	
  5719		if (cfg.fc_metric == 0)
  5720			cfg.fc_metric = IP6_RT_PRIO_USER;
  5721	
  5722		if (cfg.fc_mp)
  5723			return ip6_route_multipath_add(&cfg, extack);
  5724		else
  5725			return ip6_route_add(&cfg, GFP_KERNEL, extack);
  5726	}
  5727	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki